Version bump k8s helm chart Github Action - do you take patches?
Hello good people!
It would be awesome if the update flow for the helm chart was low-friction for everyone involved. Keeping up with releases in k8s is currently tricky 🙂
I see that https://github.com/zitadel/zitadel-charts/actions/runs/5394167158 failed, and it was the most recent run of the "bump" github action defined in https://github.com/zitadel/zitadel-charts/actions/workflows/bump.yml. There are some deprecation warnings mentioned in the output as well that probably need tending to.
Do you take pull-requests attempting to fix stuff like this? I'm not exactly sure what the fix would look like and how to verify it, but I thing it would be valuable to have "just work" and be a no brainer for everyone inside and outside the Zitadel project.
In any case, really looking forward to digging further into the Zitadel ecosystem, it's been awesome so far!
GitHub
zitadel-released · zitadel/zitadel-charts@2e2f920
This repository contains Helm charts for running ZITADEL in Kubernetes - zitadel-released · zitadel/zitadel-charts@2e2f920
GitHub
Workflow runs · zitadel/zitadel-charts
This repository contains Helm charts for running ZITADEL in Kubernetes - Workflow runs · zitadel/zitadel-charts
18 Replies
hi 👋
Thank you for the nice words!
We for sure would accept contributions that improve the experience of the helm-chart 🚀
CC @Elio
Unknown User•15mo ago
Message Not Public
Sign In & Join Server To View
Awesome! Do you know, is this flow actually being run, or is there some other process in place for updating the helm chart?
I mean, I tried to do https://github.com/zitadel/zitadel-charts/pull/193 as a one-off, is that the current fallback? (just checking)
GitHub
Update appVersion to v2.49.1, current latest release by rud · Pull ...
Update the appVersion so users of this Helm chart can just update to the latest version, and deploy v2.49.1 of Zitadel.
Anything else need to be bumped with this?
Definition of Ready
I am happy w...
Unknown User•15mo ago
Message Not Public
Sign In & Join Server To View
alright, I'll give it a whirl
Looking around a bit, an idea for initial simplification occurs: would it make sense to convert "bump.yml" into a manual (admin-only) github-action that takes a zitadel release number, and from that bumps version info in the zitadel-charts repo using most of the current logic?
That would allow the workflow to be iterated on trivially. It would make for a robust action to implement "we need to release a chart now for a security issue", even if there zitadel main repo <-> zitadel-charts webhook somehow fails, or Github had a issue with delivering webhooks.
Once such a robust workflow is in place, it should be fully possible to automatically invoke it from the main zitadel repo, given the new release number as input aka https://docs.github.com/en/actions/using-workflows/triggering-a-workflow
GitHub Docs
Triggering a workflow - GitHub Docs
about to drop offline, will check back in tomorrow
Hm yeah we could do something like this.
We already use something alike here https://github.com/zitadel/zitadel-go/commits?author=zitadel-workflow%5Bbot%5D
GitHub
Commits · zitadel/zitadel-go
ZITADEL Go - The official client library of ZITADEL for an easy integration into your Go project. - Commits · zitadel/zitadel-go
Apologies for the super long dead air, but finally a PR has appeared: https://github.com/zitadel/zitadel-charts/pull/235
GitHub
feat: bump workflow now supports manual run with an optional ZITADE...
Invoke this workflow manually when you want to create an updated Helm chart. If you pass in a ZITADEL release tag, then that is the version the new chart will use, otherwise the chart will automati...
The go workflow runs both on manual invocation and via cron. I did not want to add noise from automated cron runs before we've seen it work at least once.
But in case this turns out to be robust and still awesome change, then it's only a matter of adding these two lines: https://github.com/zitadel/zitadel-go/blob/77502a99487831a71e50ee554f6883b72a7ddbb4/.github/workflows/update-zitadel.yml#L3-L4
GitHub
zitadel-go/.github/workflows/update-zitadel.yml at 77502a99487831a7...
ZITADEL Go - The official client library of ZITADEL for an easy integration into your Go project. - zitadel/zitadel-go
Unknown User•10mo ago
Message Not Public
Sign In & Join Server To View
I'll give it another go today, thank you for the detailed feedback
Fresh PR up trying to repair this - this time I've actually been running the workflow; guessing at the behaviour in Github Actions never works. Here's the PR: https://github.com/zitadel/zitadel-charts/pull/236
GitHub
chore: helm chart bump.yml repair by rud · Pull Request #236 · zita...
With this my hope is the workflow started in #235 is now functional.
Definition of Ready
I am happy with the code
Short description of the feature/issue is added in the pr description
PR is lin...
I see the workflow gets a lot further along now, but still stumbles before the goal: https://github.com/zitadel/zitadel-charts/actions/runs/10557357540/job/29244705307
GitHub
Bump Version · zitadel/zitadel-charts@d56edf3
This repository contains Helm charts for running ZITADEL in Kubernetes - Bump Version · zitadel/zitadel-charts@d56edf3
I think these days there are some github provided actions that can perform these tasks. Should probably be a lot better supported. I'll add yet another PR. Sorry for all the back/forth on this, but I think that's the cost of collaboration across boundaries. I haven't quite run out of steam yet. Heads-up @Elio
Unknown User•10mo ago
Message Not Public
Sign In & Join Server To View
Uh, excellent, thank you for that feedback!
Should be getting quite close
Unknown User•10mo ago
Message Not Public
Sign In & Join Server To View